Skip to content

decimal docs: specification link and examples #128698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

decimal docs: specification link and examples #128698

wants to merge 6 commits into from
+26 −4

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Jan 10, 2025 •
edited by github-actions bot
Loading

  • added a direct reference to a floating-point model used
  • and few examples for formatted string output

📚 Documentation preview 📚: https://cpython-previews--128698.org.readthedocs.build/

@skirpichev
decimal docs: specification link and examples
7a335ed 
* added a direct reference to a floating-point model used
* and few examples for formatted string output
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting review labels Jan 10, 2025
@skirpichev skirpichev mentioned this pull request Jan 10, 2025
Closed
rruuaanng
rruuaanng reviewed Jan 10, 2025
View reviewed changes
StanFromIreland
StanFromIreland approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

@skirpichev skirpichev requested a review from ericvsmith January 24, 2025 02:39
@skirpichev
Copy link
Member Author

@ericvsmith, refs to format/f-strings - added.

@ericvsmith
Copy link
Member

@ericvsmith, refs to format/f-strings - added.

I think that's good. It doesn't mention str.format, but that's not so important any more and I hope that anyone who really cares about it knows that it's all based on __format__.

@skirpichev
Copy link
Member Author

It doesn't mention str.format, but that's not so important

I think this will be too verbose, it's already mention the format() builtin docs, which has links to __format__ and then to str.format()

@ericvsmith
Copy link
Member

It doesn't mention str.format, but that's not so important

I think this will be too verbose, it's already mention the format() builtin docs, which has links to __format__ and then to str.format()

Agreed.

@skirpichev skirpichev mentioned this pull request Apr 7, 2025
Merged
@skirpichev skirpichev removed the needs backport to 3.12 only security fixes label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rruuaanng rruuaanng rruuaanng left review comments

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

Assignees
No one assigned
Labels
awaiting core review docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes skip issue skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skirpichev @ericvsmith @StanFromIreland @rruuaanng